[PlanetCCRMA] Fwd: Re: [ANNOUNCE] 3.2.9-rt15

[Fernando Lopez-Lezcano]

On 03/05/2012 02:55 PM, Fernando Lopez-Lezcano wrote:
> Re: the kernel panics on shutdown, I'm building a new version of the
> kernel with this patch added...

Just released new kernel packages in testing for Fedora 16 
(3.2.9-1.rt15.2), at least my test laptop shuts down correctly now!

-- Fernando


> -------- Original Message --------
> Subject: Re: [ANNOUNCE] 3.2.9-rt15
> Date: Mon, 05 Mar 2012 17:14:00 -0500
> From: Steven Rostedt <rostedt at goodmis.org>
> To: Thomas Gleixner <tglx at linutronix.de>
> CC: LKML <linux-kernel at vger.kernel.org>, linux-rt-users
> <linux-rt-users at vger.kernel.org>, Clark Williams <clark at redhat.com>,
> "Luis Claudio R. Goncalves" <lclaudio at uudg.org>, Fernando Lopez-Lezcano
> <nando at ccrma.Stanford.EDU>
>
> Thomas,
>
> Please fold this change into
>
> cpu-rt-make-hotplug-lock-a-sleeping-spinlock-on-rt.patch
>
>
> As the patch was never tested (nor even compiled) it introduced a nasty
> bug into taking a CPU down instead of fixing one.
>
> Thanks,
>
> -- Steve
>
> diff --git a/kernel/cpu.c b/kernel/cpu.c
> index c25b5ff..66dfb74 100644
> --- a/kernel/cpu.c
> +++ b/kernel/cpu.c
> @@ -59,16 +59,20 @@ static struct {
> int refcount;
> } cpu_hotplug = {
> .active_writer = NULL,
> +#ifdef CONFIG_PREEMPT_RT_FULL
> + .lock = __SPIN_LOCK_UNLOCKED(cpu_hotplug.lock),
> +#else
> .lock = __MUTEX_INITIALIZER(cpu_hotplug.lock),
> +#endif
> .refcount = 0,
> };
>
> #ifdef CONFIG_PREEMPT_RT_FULL
> -# define hotplug_lock() spin_lock(&cpu_hotplug.lock)
> -# define hotplug_unlock() spin_unlock(&cpu_hotplug.lock)
> +# define hotplug_lock() rt_spin_lock(&cpu_hotplug.lock)
> +# define hotplug_unlock() rt_spin_unlock(&cpu_hotplug.lock)
> #else
> # define hotplug_lock() mutex_lock(&cpu_hotplug.lock)
> -# define hotplug_lock() mutex_unlock(&cpu_hotplug.lock)
> +# define hotplug_unlock() mutex_unlock(&cpu_hotplug.lock)
> #endif
>
> struct hotplug_pcp {