<div dir="ltr">Hi Gary,<br>Thanks for the response. I'm changing the frequency like this:<br><br>plucked->noteOn(freq, 1.0);<br><br>Which internally on Plucked.cpp does:<br><br>this->setFrequency( frequency );<br>
this->pluck( amplitude );<br><br><br>I understand that the length of the delay line controls the frequency, so I've printed out the parameter to "delayLine_.setDelay(delay);" in the setFrequency method of Plucked.cpp and the parameter is always the same, even when the instrument is out of tune.<br>
<br>Another interesting bit of information is that this issue would not happen on an iPhone 4, but it is prominent on an iPhone 5. Any clues?<br><br>Thanks,<br><br><br>Hector</div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Fri, Mar 8, 2013 at 6:16 AM, Gary Scavone <span dir="ltr"><<a href="mailto:gary@ccrma.stanford.edu" target="_blank">gary@ccrma.stanford.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Hector,<br>
<br>
If the note is out of tune, then there must be a problem with the delay line length. That is, it should not matter whether, or in what way, the delay line is filled with noise (though if the delay line is not filled with noise, it may not produce any sound because it won't have much energy left inside). This code is fairly old and we haven't noticed any problems over the years, so perhaps you are using it (updating the control parameters) in some way that was not expected. How are you changing the plucked note number or frequency?<br>
<br>
Regards,<br>
<br>
--gary<br>
<div><div class="h5"><br>
On 2013-03-06, at 4:38 PM, Hector Urtubia <<a href="mailto:urtubia@mrbook.org">urtubia@mrbook.org</a>> wrote:<br>
<br>
> Hi All,<br>
> I'm having issues with the Plucked instrument on iOS where sometimes notes get completely out of tune.<br>
> I took a look at the Sitar instrument, which uses a similar algorithm and doesn't show the same issue and I isolated the problem to the following lines on the "pluck" method of Plucked:<br>
><br>
> for ( unsigned long i=0; i<delayLine_.getDelay(); i++ )<br>
> // Fill delay with noise additively with current contents.<br>
> delayLine_.tick( 0.6 * delayLine_.lastOut() + pickFilter_.tick( noise_.tick() ) );<br>
><br>
><br>
> If I don't fill the delay buffer after changing the frequency, then the notes stay in tune, but then I have to modify the tick method where the timbre of the instrument is not the same at all.<br>
> Any ideas?<br>
> Regards,<br>
><br>
> Hector<br>
</div></div>> _______________________________________________<br>
> Stk mailing list<br>
> <a href="mailto:Stk@ccrma.stanford.edu">Stk@ccrma.stanford.edu</a><br>
> <a href="http://ccrma-mail.stanford.edu/mailman/listinfo/stk" target="_blank">http://ccrma-mail.stanford.edu/mailman/listinfo/stk</a><br>
<br>
</blockquote></div><br></div>